michaelmcandrew / civicrm-buildkit-docker

This is a read only copy. Please make PRs here: https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
GNU Affero General Public License v3.0
40 stars 31 forks source link

Don't always restart #33

Closed wmortada closed 5 years ago

wmortada commented 5 years ago

I've noticed that these images are always running every time I switch my laptop on. I find this slightly annoying as it means that I have to stop them in order to run other docker images that use the same ports. I would prefer to turn the images off and on as required.

The suggested changes make the images only restart on failure.

michaelmcandrew commented 5 years ago

This is interesting. I added this because, for me, having to start them each time I start my laptop was annoying me.

I also have manually maintain a list of ports for all my docker services to that non of them use the same port and (for the more common services) reverse proxy them via nginx to more friendly URLs.

I wonder if 'unless stopped' is a good compromise? What do you think about us both experimenting with that and see if it meets our needs? Unless you ruled that one out already.

wmortada commented 5 years ago

Sounds fine to me. I guess it is a matter of personal preference. I thought others may feel the same way as me but I may be wrong!

It's easy enough to keep my own version of the Dockerfile.

michaelmcandrew commented 5 years ago

@wmortada - just double checking - does unless-stopped do what you want? It does what I want so if so, I will merge

wmortada commented 5 years ago

Yes, that works fine for me. Does just what I want. I can start it when I want and it doesn't restart when I don't want it.