michaelmcandrew / civicrm-buildkit-docker

This is a read only copy. Please make PRs here: https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
GNU Affero General Public License v3.0
40 stars 31 forks source link

Switch to php 7.2 #36

Closed michaelmcandrew closed 5 years ago

michaelmcandrew commented 5 years ago

@wmortada - do you know where to find the recommended php version for civicrm?

mattwire commented 5 years ago

Here: https://docs.civicrm.org/sysadmin/en/latest/requirements/#php-version PHP7.2 is the currently recommended version.

michaelmcandrew commented 5 years ago

ah, thanks @mattwire - I was looking in https://docs.civicrm.org/dev - silly me :)

wmortada commented 5 years ago

I just did a naive test of this by updating the Dockerfile to FROM php:7.2-apache. Unfortunately this doesn't work because mcrypt was removed from PHP7.2. It looks like mcrypt isn't required for recent versions of CiviCRM so I guess the answer is to remove the relevant lines from the Dockerfile.

michaelmcandrew commented 5 years ago

@wmortada - you might want to look at https://github.com/michaelmcandrew/civicrm-buildkit-docker/tree/master/publish and the templates for creating Docker files that work with various versions of PHP, e.g. https://github.com/michaelmcandrew/civicrm-buildkit-docker/blob/3ec90aa6c506403b6415c6ae7c40d81951db4877/publish/templates/civicrm/Dockerfile.twig#L67-L72

wmortada commented 5 years ago

Ah, okay, I didn't realise you'd set this up as a template.

michaelmcandrew commented 5 years ago

we're now defaulting to php7.2 so closing