michaelmcandrew / civicrm-buildkit-docker

This is a read only copy. Please make PRs here: https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
GNU Affero General Public License v3.0
40 stars 31 forks source link

Don't load xdebug twice! #47

Closed wmortada closed 4 years ago

wmortada commented 4 years ago

See issue #46

michaelmcandrew commented 4 years ago

Referencing https://github.com/michaelmcandrew/civicrm-buildkit-docker/issues/46.

Thanks, William. Removing it from here and keeping it in debug.ini looks like the right way to do it

michaelmcandrew commented 4 years ago

@wmortada I also added https://github.com/michaelmcandrew/civicrm-buildkit-docker/commit/6ee433cd7b0fc2c9b801b620b43c4f93fb9dbac5.

The civicrm directory gets overridden here https://github.com/michaelmcandrew/civicrm-buildkit-docker/blob/73509adba3e4a961fccd74d67aff1150ae6f2e84/publish/generate.php#L21-L22 when you run publish/generate.php. So in future, rather than editing files in the civicrm directory directly, you should edit files in the publish/templates directory and then run publish/generate.php.