Currently the Dockerfile clones the repository into a temporary folder then copies the contents of this folder into the /buildkit folder. The problem is that it doesn't copy everything so the next line that tries to remove the temporary directory fails when this directory isn't empty (which is a good thing because it alerts us to the fact that not everything has been copied!).
There was a recent change to buildkit that adds a .loco directory which isn't picked up by this script. My initial thought was to add this directory to the script but that approach is liable to fail again in future there are any new .files or .directories added to buildkit.
Instead I've gone for a different approach that should hopefully be more robust.
michaelmcandrew
commented
3 years ago
Fixes #57.
Currently the Dockerfile clones the repository into a temporary folder then copies the contents of this folder into the
/buildkitfolder. The problem is that it doesn't copy everything so the next line that tries to remove the temporary directory fails when this directory isn't empty (which is a good thing because it alerts us to the fact that not everything has been copied!).There was a recent change to buildkit that adds a
.locodirectory which isn't picked up by this script. My initial thought was to add this directory to the script but that approach is liable to fail again in future there are any new .files or .directories added to buildkit.Instead I've gone for a different approach that should hopefully be more robust.