search

michaelmcandrew / civicrm-buildkit-docker

This is a read only copy. Please make PRs here: https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
https://lab.civicrm.org/michaelmcandrew/civicrm-buildkit-docker
GNU Affero General Public License v3.0
40 stars 31 forks source link

NodeJS error when creating dmaster #73

Closed MarcMichalsky closed 3 years ago

MarcMichalsky commented 3 years ago

Hi, I get the following warnings when I create a new dmaster build:

WARNING: Failed to locate command "node". NodeJS (http://nodejs.org/) is required for development of CiviCRM v4.6+.
WARNING: Failed to locate command "npm". NodeJS (http://nodejs.org/) is required for development of CiviCRM v4.6+.

Later the building process fails at this point:

./bin/setup.sh: line 153: npm: command not found

-> full log

Could this be related to issue #68 or PR #69?

wmortada commented 3 years ago

It sounds related to me but node and npm should be installed (albeit older versions). Have you tried applying #69 to see if that helps?

MarcMichalsky commented 3 years ago

Hello @wmortada, I tried your branch wmortada:68-nodejs-outdated with the same result. -> full log

MarcMichalsky commented 3 years ago

As a workaround I installed NodeJS and npm manually.

bkb
sudo apt update
sudo apt install npm
wmortada commented 3 years ago

Are you building your own container or using the one from Docker Hub? That branch will only make a difference if you are building your own container. If you could paste the commands you've used we can check.

wmortada commented 3 years ago

I'm wondering if the container on Docker Hub is missing node?

michaelmcandrew commented 3 years ago

I can replicate this, unfortunately.

I am presuming that civi-download-tools was not able to actually download node. I am running docker build civicrm and having a look at the output to see what went wrong...

MarcMichalsky commented 3 years ago

Are you building your own container or using the one from Docker Hub? That branch will only make a difference if you are building your own container. If you could paste the commands you've used we can check.

Ouch! Didn't know that, sorry. Building the docker container on your wmortada:68-nodejs-outdated branch fixed the issue. Thanks!

michaelmcandrew commented 3 years ago

@MarcMichalsky - see https://github.com/michaelmcandrew/civicrm-buildkit-docker/issues/68#issuecomment-888315091 - a new docker hub should be published overnight now...