michaelmob / WebMCam

Capture frames in real-time and save them as WebM.
GNU General Public License v3.0
284 stars 27 forks source link

Add full screen recording #67

Open fz0000 opened 5 years ago

fz0000 commented 5 years ago

I found that there was a request for this feature: #48 My team member asked for this feature today, too. (We just need a small and simple tool so They prefer WebMCam to OBS...) So I just add the options.

The most important changes are in the file FormMain.cs (and FormMain.Designer.cs). My platform is VS2017 so many other files are also changed. 😅

michaelmob commented 5 years ago

Thanks for the contributing! Sorry for the delayed response.

I'm not opposed to this, however, there should be some kind of warning to let the user know that the recording might not turn out as expected with a high resolution (such as low FPS, stutter, etc.) when switched to the fullscreen mode

There is a warning button that appears although I think it would be rendered useless when the main form is minimized. Perhaps some sort of "Are you sure?" with a remember option. Thoughts on this?

https://github.com/thetarkus/WebMCam/blob/22d96602894a83679e19a3fe4b74fef5cf643dbf/FormMain.cs#L438

fz0000 commented 5 years ago

Yes I don't recommend recording in high resolution, either. 😅

This is how the story goes: our display is only 17" (1280 x 1024) and we don't need the demo video to be that fluent. So we set the fps to 3 and the output is acceptable for us. I just add this option simply for my team's own use. Maybe there are some better designs... However, personally I prefer adding this feature, since some users might indeed need it.

I think the pop up message is a good idea since many users might ignore the warning button. And we can also reduce the default FPS value (e.g. to 5 or 10) when user resize the box to a large size or select the full screen recording option. Moreover, we can give a double warning when user click the record button... So if users insist on recording in this situation, we suppose that they have a clear conception of it and should take their own risk... 😜