michaelmulley / openparliament

Keeping tabs on Canada's Parliament
http://openparliament.ca/
GNU Affero General Public License v3.0
265 stars 42 forks source link

Version française #26

Closed arlolra closed 12 years ago

arlolra commented 12 years ago

Hi,

This pull request is a work in progress. I've started adding internationalization to the codebase. What you wrote in the wiki sounds good. Hopefully I'll find the time to see this through.

I'm mainly posting so that you are aware of my intention to help out, and, in case you have objections, my efforts aren't in vain.

Arlo

michaelmulley commented 12 years ago

Hi Arlo,

This is great!

A few notes:

arlolra commented 12 years ago

I removed the dependency on rosetta, which would only be needed on the separate site and, even then, only in development. I agree wholeheartedly that maintaining a multilingual site can introduce a lot of overhead, so keeping to different databases is probably best, though the same codebase can be used. The best tool I've found for model translation is django-hvad, but even that can be a lot of work.

I don't think there's any rush to merge this in, though at this point, there probably aren't any breaking changes. I've been running pep8 on the apps as I go through them. Making some changes helps me familiarize myself with your code. Hope that's alright.

The help you can provide is direction, encouragement and, when it comes time, translators and hosting.

arlolra commented 12 years ago

@rhymeswithcycle sorry I never finished this up. I touched too much code with pep8. Should have just stuck to adding internationalization support. I'm going to close for now and hopefully find time to restart.