Fix issue that prevented 404 from being sent in GET requests with key

michaelneu / webxcel

🤔 A REST backend built with plain VBA Microsoft Excel macros. Yes. Macros.

https://dev.to/michaelneu/to-vba-and-beyond---building-a-restful-backend-using-plain-microsoft-excel-macros-76n

MIT License

440 stars 70 forks source link

Fix issue that prevented 404 from being sent in GET requests with key #16

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hi! You haven't responded to my other Pull Requests yet. If you think they aren't good, you can just say so. I admit I don't know the "right way" to do things in VBA, but I want to help! This change is really simple! The variable value wasn't declared in that scope, so the TypeName always evaluated as "Empty". It was clear that getValue was intended.

michaelneu commented 5 years ago

If you think they aren't good, you can just say so.

Don't worry, if I had something to complain, I would've told you 😄. Also, this is a webserver in VBA, there's not really a "right way", since this is so fundamentally strange. I was just sick since ~ christmas, thus I didn't find the time to look at the PRs.

You're right, that value appears to be an error, good catch!