search

michaelnisi / feedkit

Searchable caching feed client
MIT License
3 stars 1 forks source link

trim error: Error Domain=Skull.SkullError Code=2 "(null)" #13

Closed michaelnisi closed 5 years ago

michaelnisi commented 6 years ago

Found in the user logs, after updating the queue :

trim error: Error Domain=Skull.SkullError Code=2 "(null)"

https://github.com/michaelnisi/feedkit/blob/c4243f19433c40b7b02a490c8c39b5b92499983e/FeedKit/user/UserLibrary.swift#L248

michaelnisi commented 6 years ago

We have to check error before passing it to updateComplete: ((_ newData: Bool, _ error: Error?) -> Void)?), because the error might have been bubbled up the dependency chain and thus not be a critical error.

michaelnisi commented 6 years ago

I was worried about UIBackgroundFetchResult, but AppDelegate looks at a combination of newData and error to produce the result, so, it’s fine to pass non-critical errors.