michaelnisi / pickup

Transform XML feeds

MIT License

21 stars 1 forks source link

Try using key order #15

Closed michaelnisi closed 5 years ago

michaelnisi commented 5 years ago

RFC

Here’s an experiment tying to use mappings key order to define precedence.

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling d493d065b40dbea569196c04c34e6e1a1d93c6df on precedence into 4abff16c485a7472270dbb669b00eafb08517f7a on master.

michaelnisi commented 5 years ago

This is potentially 🔥 code. Any performance regression is a problem, although we are using sax-js, which isn’t the fastest.

michaelnisi commented 5 years ago

Getting there, not only it clearer and better to read, but it’s also faster. 🙌🏼⚡️

michaelnisi commented 5 years ago

Letting it sit for a moment 🍲 maybe merge tomorrow.

michaelnisi commented 5 years ago

135e00cd4323deda68324f728d626183e48c8ac0