michaelobed / square-wave-gen

A slightly boring tool to accurately* generate square waves for test purposes.
Apache License 2.0
0 stars 0 forks source link

UART string detection may be broken on macOS #6

Closed michaelobed closed 10 months ago

michaelobed commented 10 months ago

I don't remember how, but testing it on @natty11q's Mac, I could only enter one string before no further detection occurred.

michaelobed commented 10 months ago

In my constant refactoring of the UART ISR, I forgot about the stray \n that may be received! This is a simple fix, although I don't like the fact that we're incrementing the buffer index in two places. 🥲

michaelobed commented 10 months ago

Closing for now, but I'll probably revisit this if it breaks on Windows.