search

michaeloryl / saml-encoder-decoder-js

Routines assembled to create and extract SAML assertions
GNU General Public License v2.0
9 stars 4 forks source link

Please clarify the applicable license #2

Closed alpianon closed 1 year ago

alpianon commented 2 years ago

@michaeloryl The LICENSE file contains GPLv2 text, while in package.json license is set to ISC: which one is applicable?

pombredanne commented 2 years ago

I would surmise that since npm-init was creating package.json with a default ISC license back then, this is likely the result of an oversight when generating the package.json and the code is GPL alright.

Not-really-ISC-licensed packages are a common thing in npm world because of this. This was done in https://github.com/npm/npm/pull/4618/files by @zeke and @dominic It used to be BSD-2-Clause before ISC. I could argue that any default was a bad idea.

See https://github.com/npm/init-package-json/blob/8f7efd0175232439d019bda73dffd724f6ccf315/lib/default-input.js#L298 for the npm init code in question Also the initial commit https://github.com/michaeloryl/saml-encoder-decoder-js/commit/5dfcffd55c711fe51073fa4c5bab732fc435113d is for the GPL text. So IMHO the author's licensing intention is GPL not ISC.

michaeloryl commented 2 years ago

GPL was my intent.

On Fri, Nov 18, 2022, 3:52 AM Philippe Ombredanne @.***> wrote:

I would surmise that since npm-init was creating package.json with a default ISC license back then, this is likely the result of an oversight when generating the package.json and the code is GPL alright.

Not-really-ISC-licensed packages are a common thing in npm world because of this. This was done in https://github.com/npm/npm/pull/4618/files by @zeke https://github.com/zeke and @dominic https://github.com/dominic It used to be BSD-2-Clause before ISC. I could argue that any default was a bad idea.

See https://github.com/npm/init-package-json/blob/8f7efd0175232439d019bda73dffd724f6ccf315/lib/default-input.js#L298 for the npm init code in question Also the initial commit 5dfcffd https://github.com/michaeloryl/saml-encoder-decoder-js/commit/5dfcffd55c711fe51073fa4c5bab732fc435113d is for the GPL text. So IMHO the author's licensing intention is GPL not ISC.

— Reply to this email directly, view it on GitHub https://github.com/michaeloryl/saml-encoder-decoder-js/issues/2#issuecomment-1319712770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO55CINCUU6MTUB6MU5UYLWI47U7ANCNFSM6AAAAAASDFV6QU . You are receiving this because you were mentioned.Message ID: @.***>

zeke commented 1 year ago

by @zeke and @dominic

Actually it was @domenic, but I happen to know them both! Memories...

michaeloryl commented 1 year ago

OK, I have republished to NPMjs.org with the updated license. Thanks.