search

michaelosthege / rtlive-dash-de

Static Dashboard Powering Rtlive.de
GNU Affero General Public License v3.0
1 stars 2 forks source link

Make the english, global page the default? #24

Open michaelosthege opened 3 years ago

michaelosthege commented 3 years ago

~The weekly incidence option from #22 was only implemented in global.js, so now only the global page has it.~

~Now instead of copyediting #22 in main.js, what if we just get rid of the German page entirely?~

EDIT: Looks I had a caching issue. The 7-day incidence was also added for the German page.

To compromise, we could make Germany the default country in the selection.

I see the following advantages:

What do you think, @lhelleckes @MaPePeR ?

MaPePeR commented 3 years ago

Only disadvantage I see is, that it would probably result in increased traffic for people that didn't use the global view before, because previously only the german data would be loaded. I think the global view always loads all regions summary.json and thumbnail - regardless of which filter is used. Not sure if traffic is a concern for you (surprised you use Amazon Cloud and don't host it locally at FZJ).

Another thing I prefer on the non-global page is, that the all region is always the first one. The global page requires scrolling to the bottom to see it.

Otherwise I think its a good idea.

michaelosthege commented 3 years ago

Well, the monthly costs are rising, but that's exclusively because we're uploading a lot of MCMC traces to S3. Actually we should just stop doing that (cc @lhelleckes).

grafik

One reason to use Amazon AWS was that it's quite cheap and scales really well for static sites hosted from S3 through CloudFront.

lhelleckes commented 3 years ago

I think increasing traffic on the global page is generally a nice thing that would come with your suggestion. I agree with @MaPePeR that I like the all region to be the first one. How about an option to switch languages but the page is otherwise the same? Would that be too much work? I just think it would be a pity if the language became a barrier for some people visiting the website.

michaelosthege commented 3 years ago

Ah yes, the sorting thing. I agree too that all should always be first. Having the FAQ and other HTML in both languages is not too hard, but creating the plots... So if we can do without the German plots a 🇬🇧 / 🇩🇪 switch is just a matter of showing/hiding a <div>.

lhelleckes commented 3 years ago

I would in that case make the plots English and provide the FAQ etc. in both languages.