search

michaelprimez / searchablespinner

Searchable Spinner
Apache License 2.0
314 stars 102 forks source link

Min sdk15 #20

Closed Akhil-Tripathi closed 5 years ago

Akhil-Tripathi commented 6 years ago

I have made the bare minimum changes to make it compatible with sdk versions as low as 15. @michaelprimez Thanks for your base repo.

Akhil-Tripathi commented 6 years ago

@michaelprimez removed ide induced changes

Akhil-Tripathi commented 6 years ago 
                                                                                  Hey, about the padding start and end‎ case I did place a min sdk check if I remember. I did not face the NoSuchMethod error. The purpose of this pr itself is to show others how to use the lib for lower sdk versions. I can attend to the NoSuchMethod error in a few days, won't be possible to attend to it straight away.                                                                                                                                                                                                                                                                                                                                        Sent from my BlackBerry 10 smartphone.                                                                                                                                                                                                                From: Michael KeskinidisSent: Saturday 25 November 2017 18:06To: michaelprimez/searchablespinnerReply To: michaelprimez/searchablespinnerCc: Akhil Tripathi; MentionSubject: Re: [michaelprimez/searchablespinner] Min sdk15 (#20)‎@michaelprimez commented on this pull request.

In app/build.gradle:

@@ -5,7 +5,7 @@ android { buildToolsVersion '26.0.2' defaultConfig { applicationId "gr.escsoft.michaelprimez.searchablespinnerexamples"

  • minSdkVersion 21
  • minSdkVersion 19

And what you did about the "NoSuchMethodError"? did you remove it? And what you did about paddingStart, paddingEnd? Did you fix it in the instance of the library that you use in your projects? If yes, why don't you fix it in the pr in order to help others? It is not so polite to make an uncompleted pr and then ask for other to make fixes. Probably in your projects you don't use min sdk 15 but the title of the pr is "Min sdk15" after all. I don't understand you at all...

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/michaelprimez/searchablespinner","title":"michaelprimez/searchablespinner","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/michaelprimez/searchablespinner"}},"updates":{"snippets":[{"icon":"PERSON","message":"@michaelprimez commented on #20"}],"action":{"name":"View Pull Request","url":"https://github.com/michaelprimez/searchablespinner/pull/20#discussion_r153045072"}}}