search

michaelrigart / ansible-role-interfaces

An ansible role for configuring different network interfaces
GNU General Public License v3.0
83 stars 61 forks source link

Added new options to configure interfaces & refactoring #102

Closed elcomtik closed 3 years ago

elcomtik commented 3 years ago

Added config options:

Refactored ONBOOT to evaluate bool value in similar way as DEFROUTE {{ item.onboot | bool | ternary('yes', 'no') }}

Removed empty lines that were inserted into the rendered config file.

elcomtik commented 3 years ago

I refactored templates that I've edited for adding HW address. There was some duplicity in Debian templates and blank lines in Redhat templates. I hope you will like the changes.

markgoddard commented 3 years ago

@elcomtik as a general comment, it makes it quite difficult to review a change if you mix refactoring in with a change in behaviour. IMO this would be better as two separate PRs. It's not too large, so I will review it as it is.

elcomtik commented 3 years ago

@elcomtik as a general comment, it makes it quite difficult to review a change if you mix refactoring in with a change in behaviour. IMO this would be better as two separate PRs. It's not too large, so I will review it as it is.

I'm sorry for that. Thanks for your patience.

markgoddard commented 3 years ago

Thanks