search

michaelrigart / ansible-role-interfaces

An ansible role for configuring different network interfaces
GNU General Public License v3.0
83 stars 61 forks source link

Fix regression in rendering RHEL route options #146

Closed cityofships closed 11 months ago

cityofships commented 11 months ago

Routes: splits the line rendering in two parts. CIDR, gateway & table go first, then (conditionally) options. They were previously getting silently dropped as updates to route were constrained to the inner loop while rendering was done outside.

Fixes #145

cityofships commented 11 months ago

Can you provide some info on what the problem was?

Issue #145

markgoddard commented 11 months ago

Well yes, but how does this fix it?

cityofships commented 11 months ago

Well yes, but how does this fix it?

Yeah - added that to the PR description now.

cityofships commented 11 months ago

My reference: https://www.redhat.com/sysadmin/ansible-jinja

markgoddard commented 11 months ago

My reference: https://www.redhat.com/sysadmin/ansible-jinja

Thanks. I also found https://stackoverflow.com/a/47402243 which would have been another option

bbezak commented 11 months ago

I guess similar stuff needed for debian/ubuntu? https://github.com/michaelrigart/ansible-role-interfaces/blob/master/templates/bond_Debian.j2#L83

cityofships commented 11 months ago

I guess similar stuff needed for debian/ubuntu? https://github.com/michaelrigart/ansible-role-interfaces/blob/master/templates/bond_Debian.j2#L83

Yes - I was able to reproduce it