michaelrigart / ansible-role-interfaces

An ansible role for configuring different network interfaces
GNU General Public License v3.0
83 stars 62 forks source link

subelements lookup expects a dictionary, got 'interfaces_bridge_interfaces' #2

Closed markgoddard closed 7 years ago

markgoddard commented 7 years ago

OS: RHEL 7.3 Ansible: 2.2

Configuring a bridge interface I saw the following error:

...
TASK [MichaelRigart.interfaces : Create the network configuration file for port on the bridge devices] ***
fatal: [control01]: FAILED! => {"failed": true, "msg": "subelements lookup expects a dictionary, got 'interfaces_bridge_interfaces'"}
        to retry, use: --limit @/home/stack/kayobe/ansible/net.retry

PLAY RECAP *********************************************************************
control01                  : ok=3    changed=0    unreachable=0    failed=1   

After applying the following patch:

diff --git a/tasks/bridge_configuration.yml b/tasks/bridge_configuration.yml
index 3fd31f1..916208d 100644
--- a/tasks/bridge_configuration.yml
+++ b/tasks/bridge_configuration.yml
@@ -24,7 +24,7 @@
     src: 'bridge_port_{{ ansible_os_family }}.j2'
     dest: '{{ interfaces_net_path[ansible_os_family|lower] }}/ifcfg-{{ item.1 }}'
   with_subelements:
-    - interfaces_bridge_interfaces
+    - "{{ interfaces_bridge_interfaces }}"
     - ports
   register: bridge_port_result

I saw a similar issue for the bond tasks, despite not configuring any bond interfaces:

TASK [MichaelRigart.interfaces : Create the network configuration file for slave in the bond devices] ***
fatal: [control01]: FAILED! => {"failed": true, "msg": "subelements lookup expects a dictionary, got 'interfaces_bond_interfaces'"}
        to retry, use: --limit @/home/stack/kayobe/ansible/net.retry

PLAY RECAP *********************************************************************
control01                  : ok=4    changed=0    unreachable=0    failed=1   

This was fixed with a similar patch as for the bridge error.

PR incoming.