michaelrigart / ansible-role-interfaces

An ansible role for configuring different network interfaces
GNU General Public License v3.0
83 stars 62 forks source link

WIP: trying to add IPoIB support #77

Closed pescobar closed 4 years ago

pescobar commented 4 years ago

This PR is not complete. Still needs to extend ipoib_configuration.yml with support for routes and rules but before continuing I wanted to get some feedback. I have the feeling that this PR has too much duplicated code. I am going to test a different approach to support IPoIB in a different PR to compare.

pescobar commented 4 years ago

this PR would require to define IPoIB interfaces like this:

    interfaces_ipoib_interfaces:                                                                                                                                                                                                       
      - device: ib0                                                                                                                                                                                                                    
        bootproto: static                                                                                                                                                                                                              
        address: 10.41.33.211                                                                                                                                                                                                          
        netmask: 255.255.128.0                                                                                                                                                                                                         
pescobar commented 4 years ago

closing this PR because the IPoIB support is added in https://github.com/michaelrigart/ansible-role-interfaces/pull/78