search

michaelrigart / ansible-role-interfaces

An ansible role for configuring different network interfaces
GNU General Public License v3.0
83 stars 61 forks source link

Revert "fix conditionals in tasks/main.yml" #83

Closed priteau closed 3 years ago

priteau commented 3 years ago

This reverts commit a235b504413e14a6afca90cb1823d20cdc027498. We still need to include these playbooks when no interface is being configured because we need *_interfaces_changed variables to be defined.

Closes #82.

/cc @pescobar @markgoddard

pescobar commented 3 years ago

If you always need to run those tasks wouldn't be better to just remove the conditionals?

What's the point of a conditionals that should be always true? IMO makes the playbook harder to read

markgoddard commented 3 years ago

If you always need to run those tasks wouldn't be better to just remove the conditionals?

What's the point of a conditionals that should be always true? IMO makes the playbook harder to read

You are right, they could be removed. I just wanted to get a fix out quickly.

pescobar commented 3 years ago

Sure. I understand. Sorry for introducing this issue :|