Add pre up option - Githubissues

michaelrigart / ansible-role-interfaces

An ansible role for configuring different network interfaces

GNU General Public License v3.0

83 stars 61 forks source link

Add pre up option #94

Closed smutel closed 3 years ago

smutel commented 3 years ago

Hello,

Add ansible manage comment on top of each template
Add an option to setup pre-up command
Avoid multiple spaces in network interfaces configuration file

michaelrigart commented 3 years ago

@smutel : thank you for the PR. Is it possible to change the pre-up variable to use an underscore instead of a dash and perhaps document it in the readme?

@markgoddard : I don't see any issues adding the option. Any other remarks?

markgoddard commented 3 years ago

@michaelrigart, I'll take a look shortly.

smutel commented 3 years ago

I did the requested changes.
I put something in the README, however it does not contain array with a list of variables so I don't know if I put the description in the good place.

markgoddard commented 3 years ago

Released as v1.10.0