michaelrommel / nvim-silicon

neovim plugin to create code images using the external silicon tool.
MIT License
110 stars 8 forks source link

feat: add `--window-title` support #1

Closed andresatierf closed 1 year ago

michaelrommel commented 1 year ago

Hey André,

thanks a lot for this PR. Initially I had a little trouble understanding, which version now supports this command line flag. Now I found it, it is still on master only, not released yet. I have now build a version to test your suggestion...

One thing I found is, that because you compacted the three similar cases 'language', 'output' and 'window-title' together (which is nice!), the filename no longer gets set and the function, that prints out the filename around line 103 would no longer get the name. So I need to workaround this. Also 'value' in lines 42 and 44 need to be local, otherwise they end up as global variables. I'll think about a way to retain your suggestions to make the code more compact.

Thanks!!

Michael.