search

michaelrommel / nvim-silicon

neovim plugin to create code images using the external silicon tool.
MIT License
110 stars 8 forks source link

Fix: Background Image can not be set as Background color has in Non-nullifiable default #8

Closed dangtrivan15 closed 4 months ago

dangtrivan15 commented 4 months ago

Context

As the 2 arguments can not be supplied together (as per silicon warning), a default background argument cause background_image impossible to be injected.

Solution

Remove default background argument, let the silicon binary decide.

michaelrommel commented 4 months ago

Thanks! Interesting - did you try in your original config before the patch to set the background color to nil and then set the background image? Maybe that tbl_deep_extend does then not overwrite the original value with nil, I have to check that...

michaelrommel commented 4 months ago

Confirmed, a nil value doesn't even show up in the input opts table.