michaelrsweet / hp-printer-app

Example printer application for HP PCL printers using PAPPL.
Apache License 2.0
35 stars 7 forks source link

LaserJet Driver Doesn't Seem to Produce Correct Output #12

Closed sjoubani closed 2 years ago

sjoubani commented 3 years ago

Describe the bug LaserJet driver doesn't seem to produce correct (though uncompressed) PCL output when compared with ippevecpl(7), also printer page is blank.

To Reproduce Steps to reproduce the behavior:

  1. Compile for macOS (10.15, libpng 1.6.37, libusb 1.0.24, libjpeg 9d, PAPPL 1.0.3, h-p-a 66aba65)
  2. Run as a server on macOS 12 Beta 5
  3. Add a network printer with its .local hostname and the HP LaserJet driver
  4. Add the printer as AirPrint on the same machine
  5. Print a PDF

Expected behavior Correct PDF output at the printer

Screenshots output.zip PDF: original job, URF: cupsfilter(8) output, PCL: ippevepcl(7) output from URF, HPA: h-p-a output captured using lldb(1)

System Information:

Additional context Replaced the only occurrence of strdup(3) with memcpy(3) to prevent a buffer overflow and memory leak.

michaelrsweet commented 2 years ago

OK, I think I've fixed this issue and will be doing an actual release in the near future.