search

michaelrsweet / hp-printer-app

Example printer application for HP PCL printers using PAPPL.
Apache License 2.0
35 stars 7 forks source link

Typos in media size list, eliminating A4 media size #8

Closed tillkamppeter closed 2 years ago

tillkamppeter commented 3 years ago

Some commas are missing, making the A4 paper size disappearing from the menus in the Printer Applicationm. The following patch fixes it:

diff --git a/hp-printer-app.c b/hp-printer-app.c
index 5288f67..077a8fb 100644
--- a/hp-printer-app.c
+++ b/hp-printer-app.c
@@ -59,7 +59,7 @@ static const char * const pcl_generic_pcl_media[] =
   "na_legal_8.5x14in",
   "na_letter_8.5x11in",
   "na_executive_7x10in",
-  "iso_a3_297x420mm"
+  "iso_a3_297x420mm",
   "iso_a4_210x297mm",
   "iso_a5_148x210mm",
   "jis_b5_182x257mm",
@@ -76,7 +76,7 @@ static const char * const pcl_hp_laserjet_media[] =
   "na_legal_8.5x14in",
   "na_letter_8.5x11in",
   "na_executive_7x10in",
-  "iso_a3_297x420mm"
+  "iso_a3_297x420mm",
   "iso_a4_210x297mm",
   "iso_a5_148x210mm",
   "jis_b5_182x257mm",
michaelrsweet commented 2 years ago

[master 474690c] Fix broken paper size list (Issue #8)