michaelrsweet / lprint

A Label Printer Application
https://www.msweet.org/lprint
Apache License 2.0
227 stars 31 forks source link

Revert DYMO label margins to values prior to DYMO tape printing being added #132

Open ribbons opened 6 months ago

ribbons commented 6 months ago

When DYMO tape printing support was added in ed195b5233 and 6f49c6e066, the label left_right margin was changed from 100 to 367 and the bottom_top margin from 525 to 1.

In my limited testing (I currently only have a LabelWriter 450 and 1.4 x 3.5" Large Address labels to test it with), these values cause the label content to be offset both vertically and horizontally with respect to the label. For instance, after selecting the correct media, printing the test page gives me this result (next label manually ejected too for clarity):

before

The commit in this PR restores the values to what they were prior to ed195b5233 and gives me the following result from the test page:

after

This was initially a bit of a head-scratcher for me because I hadn't realised that the margins are stored in the state file and only updated when media is selected (or re-selected).