michaelrsweet / lprint

A Label Printer Application
https://www.msweet.org/lprint
Apache License 2.0
219 stars 29 forks source link

Add warnings to cflags and fix for ZPL naming #60

Closed henrikjuul closed 2 years ago

henrikjuul commented 2 years ago

I noticed a Wformat-truncation warning while compiling lprint, even though configure checks that the warning can be disabled.

I've tried to fix it by adding it to CFLAGS in configure{.ac}, as it seemed as the simplest solution. I also tried a fix for the warning - I guess printer names > 1020 characters would be unusual anyway?

And I then couldn't understand why the newname wasn't used, so I tried to make sense of it (Untested, I don't have multiple ZPL printers)

I've separated it into three patches, so feel free to cherry pick if any of it is of use.

michaelrsweet commented 2 years ago

[master ba2aa9c] Configure fix and a change to how printer name conflicts are handled (Issue #60)