michaelrsweet / lprint

A Label Printer Application
https://www.msweet.org/lprint
Apache License 2.0
227 stars 31 forks source link

pappl f99d12f after 1.2.1 lost compatibility with cups 2.2.x again #67

Closed janwilmans closed 2 years ago

janwilmans commented 2 years ago

lprint (or actually pappl) == v1.1.0 builds ok on debian 10 (buster) using CUPS v2.2.1

However, all versions after that do not, and I get this error: (which makes sense because IPP_OP_CREATE_SYSTEM_SUBSCRIPTIONS never made it into a cups 2.2.x release.)

subscription-ipp.c: In function ‘_papplSubscriptionIPPCreate’:
subscription-ipp.c:120:189: error: ‘IPP_OP_CREATE_SYSTEM_SUBSCRIPTIONS’ undeclared (first use in this function); did you mean ‘IPP_OP_CREATE_PRINTER_SUBSCRIPTIONS’?
  120 |   if (ippGetOperation(client->request) == IPP_OP_CREATE_JOB_SUBSCRIPTIONS || ippGetOperation(client->request) == IPP_OP_CREATE_PRINTER_SUBSCRIPTIONS || ippGetOperation(client->request) == IPP_OP_CREATE_SYSTEM_SUBSCRIPTIONS)
      |                                                                                                                                                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                                                                                                                             IPP_OP_CREATE_PRINTER_SUBSCRIPTIONS
subscription-ipp.c:120:189: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [../Makedefs:75: subscription-ipp.o] Error 1
make: *** [Makefile:28: all] Error 1
michaelrsweet commented 2 years ago

@janwilmans PAPPL 1.2.1 fixes builds against versions of CUPS prior to 2.2.6.

janwilmans commented 2 years ago

So I guess to build lprint (head) using CUPS 2.2.x, I need to build against pappl 1.2.1 I will give that a try.

janwilmans commented 2 years ago

f99d12f (current master)

again, doesn't build against CUPS 2.2.x

Also libgnutls28-dev is missing from this list of dependencies:

https://github.com/michaelrsweet/pappl/blob/master/BUILD.md image

image

image

michaelrsweet commented 2 years ago

@janwilmans PAPPL supports both OpenSSL and GNU TLS. The BUILD.md dependencies list the OpenSSL package...

janwilmans commented 2 years ago

@janwilmans PAPPL supports both OpenSSL and GNU TLS. The BUILD.md dependencies list the OpenSSL package...

Yes, you're right, I didn't re-run ./configure after installing OpenSSL , sorry about the false-positive