search

michaelrsweet / lprint

A Label Printer Application
https://www.msweet.org/lprint
Apache License 2.0
219 stars 29 forks source link

Revert "Update configure script to no longer directly reference libcu… #84

Closed zdohnal closed 1 year ago

zdohnal commented 1 year ago

…ps."

This reverts commit 3a5aa5018bcaa14ef1440f731fc7fcca2a45f848.

Part of #80 .

michaelrsweet commented 1 year ago

Can't revert, will need a different "restoration" (to support libcups3) or just remove the dependency on pwgMediaForPWG completely.

zdohnal commented 1 year ago

@michaelrsweet the idea was to temporary fix CI by reverting the issue, so we know whether any new PR actually breaks the project.

After pwgMediaForPWG is removed, the libcups dependency can be removed once more.

Currently I have written a wrapper for pwgMediaForPwg function for PAPPL, which then can be used in lprint - WDYT? IMO it was a better solution than hard dependency on libcups for one function or defining the function in lprint.

michaelrsweet commented 1 year ago

@zdohnal I'd rather not add wrappers for CUPS functions. Better to make sure that the pappl.pc file includes the CUPS library configure options. I already do that for the static library configuration...