michaelrsweet / mxml

Tiny XML library.
https://www.msweet.org/mxml
Apache License 2.0
426 stars 157 forks source link

build: Don't use libtool. #282

Closed orbea closed 3 years ago

orbea commented 3 years ago

When building mxml with slibtool (https://dev.midipix.org/cross/slibtool) the install fails.

rdlibtool: error: --mode must be specified.
make: *** [Makefile:158: install-libmxml.so.1.6] Error 2

This is because Makefile.in uses $(LIBTOOL) without specifying --mode which is incorrect. GNU libtool silently accepts this for some reason... Additionally given the current build system using $(LIBTOOL) at all is pointless.

Also see this downstream issue: https://bugs.gentoo.org/780060 And similar merged fix for cups: https://github.com/OpenPrinting/cups/pull/11