search

michaelrsweet / mxml

Tiny XML library.
https://www.msweet.org/mxml
Apache License 2.0
426 stars 157 forks source link

`make install` still fails #314

Closed fxcoudert closed 1 month ago

fxcoudert commented 1 month ago

./configure --enable-shared --disable-debug --disable-dependency-tracking --prefix=/opt/homebrew/Cellar/libmxml/4.0.0 --libdir=/opt/homebrew/Cellar/libmxml/4.0.0/lib && make install gives:

  ==> make install
  Installing libmxml4.so to /home/linuxbrew/.linuxbrew/Cellar/libmxml/4.0.1/lib...
  Installing libmxml4.a to /home/linuxbrew/.linuxbrew/Cellar/libmxml/4.0.1/lib...
  mkdir: cannot create directory ‘/home/linuxbrew/.linuxbrew/Cellar/libmxml/4.0.1/lib’: File exists
  make: *** [Makefile:245: install-libmxml4.a] Error 1
  make: *** Waiting for unfinished jobs....

In version 4.0.1 https://github.com/Homebrew/homebrew-core/pull/166898

michaelrsweet commented 1 month ago

Not sure why it is erroring out (install-sh shouldn't care if the destination already exists) but let me see what is going on...

michaelrsweet commented 1 month ago

Add "-j1" to your "make install" command - it is running the two install targets in parallel, which causes the error.

I will update the makefile to force the install targets to run one at a time (.NOTPARALLEL).

michaelrsweet commented 1 month ago

[master b4dfd13] Add NOTPARALLEL GNU make extension to avoid install errors (Issue #314)

I won't be releasing this right away but sometime early next week. In the meantime use "-j1" (or set the MAKEFLAGS environment variable accordingly).

chenrui333 commented 1 month ago

@michaelrsweet Thanks for the quick turnaround, can you tag the commit and cut a new release? 🙏

michaelrsweet commented 1 month ago

@chenrui333 Like I said, I'll hold off until early next week (maybe Monday, we'll see) in case other bugs get reported in the meantime.

chenrui333 commented 1 month ago

works for me. 👍