search

michaelrsweet / mxml

Tiny XML library.
https://www.msweet.org/mxml
Apache License 2.0
451 stars 163 forks source link

HAVE_LONG_LONG_INT defined but not used #335

Closed chad-earthscope closed 29 minutes ago

chad-earthscope commented 3 hours ago

In my use case I need very few configuration options, only --disable-shared --enable-threads. The resulting config.h only contains:

#  define MXML_VERSION "Mini-XML v4.0.3"
#  define HAVE_LONG_LONG_INT 1
#  define HAVE_PTHREAD_H 1

The HAVE_LONG_LONG_INT is not used in the code.

It would be useful to be able to set configuration options via compiler command line defines, in my case just for threading support, and to avoid needing autoconf/configure completely for what I suspect are many use cases.

autoconf is kinda slow, but more importantly can be finicky on end users systems, especially after going through systems like git that change file modification times. This seems very close to being unnecessary (for my case and I suspect others).

Also, thank you very much for this library. I have been relying on Mini-XML for ~14 years!

michaelrsweet commented 2 hours ago

You can always provide your own config.h and makefile (or other project file), much as is already present in the vcnet and xcode directories.

I'll investigate the HAVE_LONG_LONG_INT issue.

michaelrsweet commented 40 minutes ago

[master 2741eca] Drop long long config tests (Issue #335)

michaelrsweet commented 29 minutes ago

OK, so short of adding a "linux" subdirectory with a makefile and config script, I don't see dumping autoconf. The config.h file is short for Mini-XML, but the configure script also determines how (and whether) to make shared/static libraries, where to install things, etc.