Printing on custom page size does not work, tray with custom page size not accepted as default

[tillkamppeter]

After adding custom page size support to the PostScript Printer Application I have set the page size of one tray to a custom size on the "Media" page and then selected this tray as default on "Printing Defaults". After that I have left the "Printing Defaults" page to get to another page of the web interface and clicked into "Printing Defaults" again, finding that the other tray (using one of the standard size) was selected as default. The log showed:

Unsupported media-default=custom_custom_5.5x11in_5.5x11in

I checked the code and found the problem. Here is the patch to fix it:

diff --git a/pappl/printer-driver.c b/pappl/printer-driver.c
index d5b37ec..4bf3acf 100644
--- a/pappl/printer-driver.c
+++ b/pappl/printer-driver.c
@@ -1212,8 +1212,8 @@ validate_defaults(

       if (pwg->length > max_length)
         max_length = pwg->length;
-      if (pwg->length > max_length)
-        max_length = pwg->length;
+      if (pwg->length < min_length)
+        min_length = pwg->length;
     }
   }

With this change custom page sizes work as intended.

[michaelrsweet]

[master 64d4b4d] Fix an issue with validation of custom media sizes (Issue #120)