search

michaelrsweet / pappl

PAPPL - Printer Application Framework
https://www.msweet.org/pappl
Apache License 2.0
310 stars 50 forks source link

“orientation-requested-default” cannot be set #313

Closed szlt5 closed 11 months ago

szlt5 commented 11 months ago

Describe the bug “orientation-requested-default” cannot be set by IPP operation "IPP_OP_SET_PRINTER_ATTRIBUTES"

To Reproduce Steps to reproduce the behavior:

  1. Run below command to set "orientation-requested-default" as "landscape". 
    printer-app modify -d foo -o orientation-requested=landscape
  2. Run below command to get "orientation-requested" 
    printer-app options -d foo | grep orientation-requested | grep default
  3. The output is -o orientation-requested=none (default)

Expected behavior The output should be -o orientation-requested=landscape (default)

Additional context The bug can be fixed by adding below code in the function papplPrinterSetDriverDefaults().

printer->driver_data.orient_default = data->orient_default;
michaelrsweet commented 11 months ago

[v1.4.x eab6b93] Set orient_default value (Issue #313)

Was already fixed in master...