michaelrsweet / pappl

PAPPL - Printer Application Framework
https://www.msweet.org/pappl
Apache License 2.0
309 stars 49 forks source link

Web Interface: Show boolean options as check box #85

Closed tillkamppeter closed 3 years ago

tillkamppeter commented 3 years ago

If a vendor option is boolean, as "vendor-boolean" of the "Label Printer" in the example Printer Application of PAPPL (see screen shot), the web interface should not show a drop-down of the two choices "true" and "false" but, instead, a check box, with checked meaning true and unchecked meaning false.

This is much more user-friendly than showing "true" and "false" to not programming-aware users.

Screenshot from 2020-11-22 22-42-10

michaelrsweet commented 3 years ago

[master 2b5273c] Fix boolean options to use checkbox (Issue #85)

tillkamppeter commented 3 years ago

Thanks, is displayed correctly now, but does not actually work. If I check the box and click the button to save my changes the box gets unchecked again, also if I leave the "Printing Defaults" and come back later, the box is always unchecked.

michaelrsweet commented 3 years ago

[master e06079e] Fix checkbox - "on" not "checked" for set value (Issue #85)