search

michaelruocco / embedded-mysql-plugin

gradle plugin for embedded mysql
17 stars 8 forks source link

Multiply schema support #12

Closed kiakimov closed 5 years ago

kiakimov commented 5 years ago

please review, this is additional schemas support plugin can be configured as

url = jdbc:mysql://xxxx/schema1
schema = schema2, schema3

or even

url = jdbc:mysql://xxxx/schema1
schema = schema1, schema2

or without schema property (as usual)

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.09%) to 99.324% when pulling 974fe4f3f5fc7a6a87e0ef6a5915d107458685ae on kiakimov:multiply_schema into b035f317666706475ce180f87658af6e2ee6a73e on michaelruocco:master.

michaelruocco commented 5 years ago

@kiakimov generally this looks fine, would you mind updating the readme as well so that in includes an example that shows how to configure using your new schema option under a new heading? Other than that it looks fine and I am happy to merge. Thanks for contributing again!

kiakimov commented 5 years ago

Hey @michaelruocco I just force pushed readme changes, please review. Thank you!

michaelruocco commented 5 years ago

@kiakimov I have just merged this change and released to maven central as version 2.1.8. Alternatively you can pull it from: https://plugins.gradle.org/plugin/com.github.michaelruocco.embedded-mysql-plugin

It should be available shortly, thanks again for the contribution.