search

michaelryanmcneill / shibboleth

Shibboleth plugin for WordPress
https://wordpress.org/plugins/shibboleth/
19 stars 11 forks source link

Option for custom prefix other than REDIRECT_ #27

Closed dellch closed 6 years ago

dellch commented 6 years ago

Our service provider adds an additional prefix (specifically UFShib_, in this situation), so in my case the entire prefix is REDIRECT_UFShib_.

Been using your plugin for a while and have always just edited the .php, but a textbox would be nice. I might be able to help w/ this sometime in the next month, but let me know your thoughts on the best way to incorporate this. (Override the dropdown list and hand input the prefix in a textbox? some other way?)

jrchamp commented 6 years ago

If UFShib_ is always present, wouldn't this just be in the textbox that's already present for each field?

michaelryanmcneill commented 6 years ago

I agree with @jrchamp here, I'm not sure why the existing text box for the attributes isn't sufficient. Can you provide additional details if that doesn't solve your issue?

dellch commented 6 years ago

Shib_Session_ID also needs the prefix

michaelryanmcneill commented 6 years ago

Ah, that does make sense. I'll target this for 2.1 and if you can spend some time making a PR, that'd be great. I'd like to add a "Custom" prefix option and have a hidden text field that appears when the "Custom" prefix option is selected in the dropdown.

jrchamp commented 6 years ago

How are you modifying the Shib-Session-ID parameter? That's supposedly hardwired. If these can be (now or in the future) customized, it may be better to add a text box to specify this value.

michaelryanmcneill commented 6 years ago

Taking a shot in the dark, I'm guessing that whatever is redirecting the attribute (REDIRECT_) is adding the additional prefix.

dellch commented 6 years ago

I think @michaelryanmcneill is right, although I'm not involved in the Identity provider of our organization, but I think they chose to do it because legacy web applications used similar variable/header names for so they prefixed with UFShib_ to show that the shibboleth provider was vending.

michaelryanmcneill commented 6 years ago

This should be resolved by 18ee3c7.