search

michaelryanmcneill / shibboleth

Shibboleth plugin for WordPress
https://wordpress.org/plugins/shibboleth/
19 stars 11 forks source link

Use sanitize_title rather than sanitize_user for user_nicename #4

Closed jrchamp closed 6 years ago

jrchamp commented 6 years ago

user_nicename is often used for URLs as a slug to the user. Comparing the documentation for the two functions, sanitize_title is the one that generates a URL-safe slug.

https://codex.wordpress.org/Function_Reference/sanitize_title https://codex.wordpress.org/Function_Reference/sanitize_user

michaelryanmcneill commented 6 years ago

This looks good to me.