search

michaelryanmcneill / shibboleth

Shibboleth plugin for WordPress
https://wordpress.org/plugins/shibboleth/
19 stars 11 forks source link

shibboleth_getoption: Simplify code #45

Closed jrchamp closed 6 years ago

jrchamp commented 6 years ago

There was a bit of duplication and the constant variable was not always defined before use.

michaelryanmcneill commented 6 years ago

For the specific example I'm speaking of, see here: https://github.com/michaelryanmcneill/shibboleth/blob/2.1-alpha/options-admin.php#L193-L215.

jrchamp commented 6 years ago

This is fixed by #46