search

michaelsharman / LT

A utility library of helper modules useful if you're developing with Learnosity APIs.
MIT License
0 stars 2 forks source link

LT-53437 - Add logic to support translation #1

Closed Nhinlee closed 1 month ago

michaelsharman commented 5 months ago

Actually, it's much easier to use API label bundles to change the label. The original thought was to make this simple, but if you want to change en to ja then you'll likely want to change "limit" as well. This means you'll have to use label bundles.

At this stage I think we close the PR, unless there's a reason to include a check for the question container.

Nhinlee commented 5 months ago

Actually, it's much easier to use API label bundles to change the label. The original thought was to make this simple, but if you want to change en to ja then you'll likely want to change "limit" as well. This means you'll have to use label bundles.

At this stage I think we close the PR, unless there's a reason to include a check for the question container.

Hi @michaelsharman, I doing this PR for workaround solution; We can consider to improve later 🙏

michaelsharman commented 1 month ago

See this commit https://github.com/michaelsharman/LT/commit/f42846f732857b138dbf0527b32ff77cbcb47758