search

michaelsharman / LT

A utility library of helper modules useful if you're developing with Learnosity APIs.
MIT License
0 stars 2 forks source link

Image uploader extension: Directly embed loading spinner svg? #7

Closed MichaelHeydon closed 1 week ago

MichaelHeydon commented 1 week ago

Hi again Michael. I'm wondering if you'd be open to directly embedding the loading spinner svg that's used on the <button> while the image is uploading? So rather than using Uploading <span class="lt__upload-spinner"><img src="${spinner}"</span> the svg is added directly within the <span> element.

This is to avoid needing to reference an additional image file when using the extension and ensuring it's properly referenced.

MichaelHeydon commented 1 week ago

Alternatively, would it be possible to just reference the .lrn-spinner-save class used elsewhere within the authoring workflow?

michaelsharman commented 1 week ago

Hi Michael,

I've moved the svg to be inline and bumped the version to 2.13.2

Thanks, Michael

On Thu, Jun 27, 2024 at 11:15 AM Michael Heydon @.***> wrote:

Alternatively, would it be possible to just reference the .lrn-spinner-save class used elsewhere within the authoring workflow?

— Reply to this email directly, view it on GitHub https://github.com/michaelsharman/LT/issues/7#issuecomment-2192874667, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFCB5DKVIUPOOQQDWUHXBTZJNRRXAVCNFSM6AAAAABJ6ZFFSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSHA3TINRWG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- michaelsharman.com

michaelsharman commented 1 week ago

Make that 2.13.3

On Thu, Jun 27, 2024 at 1:46 PM Michael Sharman @.***> wrote:

Hi Michael,

I've moved the svg to be inline and bumped the version to 2.13.2

Thanks, Michael

On Thu, Jun 27, 2024 at 11:15 AM Michael Heydon @.***> wrote:

Alternatively, would it be possible to just reference the .lrn-spinner-save class used elsewhere within the authoring workflow?

— Reply to this email directly, view it on GitHub https://github.com/michaelsharman/LT/issues/7#issuecomment-2192874667, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFCB5DKVIUPOOQQDWUHXBTZJNRRXAVCNFSM6AAAAABJ6ZFFSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSHA3TINRWG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- michaelsharman.com

-- michaelsharman.com

MichaelHeydon commented 1 week ago

Thanks for that.