search

michaelsproul / rust_radix_trie

Fast generic radix trie implemented in Rust
https://docs.rs/radix_trie/
MIT License
184 stars 32 forks source link

Make TrieNode private #31

Closed michaelsproul closed 7 years ago

michaelsproul commented 7 years ago

I read the docs for privacy and was pleasantly surprised by the actual simplicity of the rules. The good news is, TrieNode can be made private without too much fuss. The iterators still need to be fixed though.

michaelsproul commented 7 years ago

cc @roblabla @andrewcsmith

roblabla commented 7 years ago

:+1:

andrewcsmith commented 7 years ago

Looks great. Doesn't break any of my code for the markov / voting experts lib. Is there a reason IntoIterator doesn't work? I couldn't see one, but also didn't look very hard.

michaelsproul commented 7 years ago

@andrewcsmith Do you mean creating a Trie from an iterator? I don't think we ever had an IntoIterator implementation.

michaelsproul commented 7 years ago

I'm gonna merge this as I don't the iterator issue is linked?