search

michaeltouati / ESVM

Finite-volume Vlasov-Maxwell code for Plasma Physics simulations
GNU General Public License v3.0
14 stars 3 forks source link

No references in paper? #12

Closed tclune closed 3 years ago

tclune commented 3 years ago

Referencing: openjournals/joss-reviews#3618

JOSS wants: "References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?"

michaeltouati commented 3 years ago

Yes, I copied / pasted the bibtex code provided by the publishers for each reference

tclune commented 3 years ago

OK - it was empty when I opened paper.md I thought maybe the intent had been to connect them up somehow in a human readable manner. If the existing approach is as intended that is fine.

michaeltouati commented 3 years ago

The references are within the text of paper.md but located in paper.bib

When I compile the paper.md file with the provided tool :

https://whedon.theoj.org/

it eorks fine.

tclune commented 3 years ago

OK - looks good. I did have a PDF from my initial review a few weeks back and that was lacking references to, so I made assumptions. You may want to add something in the readme file that directs users to the whedon site for generating the paper. I would not have gotten there without your help above.

michaeltouati commented 3 years ago

I think it will be better if I replace the paper.md file and the paper.bib file in the repository directly by the .pdf file generated with the JOSS tool once the paper will be published (hoping it will)