Closed jcbertin closed 9 years ago
Making the returned pointer a const void * does make sense only if the methods were changed to const methods, but in the patch I only change the buffer parameter to inform that the parameter is left untouched by these methods.
Hmm, I don't think this is really true to the const philosophy - if the returned pointer was a const void , it might make sense, but there's the full expectation that that memory will be written to, at least for the 'tail' method. I could probably get behind making the 'head' method const, and have it return a const void , but otherwise I think this is misleading.