michaeluno / admin-page-framework

Facilitates WordPress plugin and theme development.
http://admin-page-framework.michaeluno.jp/
Other
340 stars 71 forks source link

Convert tabs into 4 spaces in the source code #117

Closed michaeluno closed 10 years ago

michaeluno commented 10 years ago

I've realized that tabs don't get displayed nicely when the code is displayed in a web page such as on GitHub, Gist, and the wordPress.org plugin pages.

I'll simply replace tabs with 4 white spaces for indents and one white space for alignments. Though the conversion will lose all the alignments (maybe they did not aligned at all in other code editors anyway).

After applying the conversion, the code will look like this.

        self::$sFilePath = $sFilePath ? $sFilePath : __FILE__;
        self::$sDirPath = dirname( self::$sFilePath );
        self::$sFileURI = plugins_url( '', self::$sFilePath );
        self::$sAutoLoaderPath = self::$sDirPath . '/utility/AdminPageFramework_RegisterClasses.php';
        self::$bIsMinifiedVersion = ! file_exists( self::$sAutoLoaderPath );

And I'd like to see it like,

        self::$sFilePath            = $sFilePath ? $sFilePath : __FILE__;
        self::$sDirPath             = dirname( self::$sFilePath );
        self::$sFileURI             = plugins_url( '', self::$sFilePath );
        self::$sAutoLoaderPath      = self::$sDirPath . '/utility/AdminPageFramework_RegisterClasses.php';
        self::$bIsMinifiedVersion   = ! file_exists( self::$sAutoLoaderPath );

Anyhow, it would be appreciated if anybody takes a chance to fix those alignments.

michaeluno commented 10 years ago

If you are willing to help this change, please fork this branch. https://github.com/michaeluno/admin-page-framework/tree/3.1.4b

michaeluno commented 10 years ago

Tab conversion has been done. Code alignment is something that can be done over time.