michaeluno / admin-page-framework

Facilitates WordPress plugin and theme development.
http://admin-page-framework.michaeluno.jp/
Other
339 stars 71 forks source link

Confirmation of executable script in the framework #168

Closed premiumsupport365 closed 9 years ago

premiumsupport365 commented 9 years ago

Hi Micheal

When I tried to attach the framework in the gmail, I found that it gives a warning and denied to send as it has an executable script. I saw one vbscript used for compiling css. Is that the reason.

Just wonder if this could be a reason code canyon or theme forest might deny our works.

michaeluno commented 9 years ago

Hi,

I just tried to attach a zip file that contains .vbs file to a Gmail email and got a message "Blocked for security reasons!". Following the link they provide, I found this information

You can't send or receive the following file types: .ade, .adp, .bat, .chm, .cmd, .com, .cpl, .exe, .hta, .ins, .isp, .jse, .lib, .lnk, .mde, .msc, .msp, .mst, .pif, .scr, .sct, .shb, .sys, .vb, .vbe, .vbs, .vxd, .wsc, .wsf, .wsh Messages containing the types of files listed above will be bounced back and returned to the sender automatically.

source: https://support.google.com/mail/answer/6590?hl=en

Thanks for the heads-up.

Just wonder if this could be a reason code canyon or theme forest might deny our works.

Are you including the test and tool folders (and the fies)? You should make sure only the minified version of the framework is included in your work.

Update:

I saw one vbscript used for compiling css. Is that the reason.

To be clear, the php script php-class-files-minifier.php is the one that compresses CSS rules defined in the framework. The run.vbs file which resides in the same directory only runs php-class-files-minifier.php. You can even view what are written in the script.

There are currently three vbscript files that are included in the repository. They are located in the followings and what they do is what is described above which just runs the PHP script.

And the tool and test directories have become not to be included if you just download the zip file. It became to be so around v3.3.1 as far as I remember.

premiumsupport365 commented 9 years ago

Hi Michael ,

I hope we dont use the minifier in our pugin at this stage. can we exclude the script safely from the package and if so which file needs to be altered.

michaeluno commented 9 years ago

The minifier script and the related files reside in the tool directory. And it is already excluded from the distribution packages since v3.3.1 or so if I remember correctly.

premiumsupport365 commented 9 years ago

@michaeluno I see its removed. Thanks again :)

michaeluno commented 9 years ago

Glad it helped!

As I checked it again, it is v3.3.2 that started dropping the tool directory from the distribution package.