michaeluno / admin-page-framework

Facilitates WordPress plugin and theme development.
http://admin-page-framework.michaeluno.jp/
Other
340 stars 71 forks source link

Warning after purchasing Field Types Pack #191

Closed vladkucherov closed 9 years ago

vladkucherov commented 9 years ago

Hi,

I get the warning:

Strict Standards: Declaration of EDDSoftwareLicensingCustomFieldType::doOnFieldRegistration() should be compatible with AdminPageFramework_FieldType::doOnFieldRegistration(array $aField) in /home/***/wp-content/plugins/admin-page-framework-field-type-pack/include/library/cutom-field-types/edd-software-licensing/EDDSoftwareLicensingCustomFieldType.php on line 3

In this case you should change from (Line 108):

protected function doOnFieldRegistration( $aField ) {

to:

protected function doOnFieldRegistration( array $aField ) {

Also I wanted to know how I should receive updates ?

michaeluno commented 9 years ago

Thanks for the report.

I see. I think the type hinting in the doOnFieldRegistration() method parameter in the AdminPageFramework_FieldTyp class should be dropped because the method is meant to be used by framework users who write own custom field types. And this kind of mistake is easy to make.

Also I wanted to know how I should receive updates ?

Go to Dashboard -> Admin Page Framework -> Field Type Pack and then enter your license key printed on the purchase receipt. If you successfully activate the license, you'll get updates. One way to test it is to manually decrease the version number of the add on.

michaeluno commented 9 years ago

v3.5.1.1 has been released which fixes this issue.