Sortable checkbox problem

mnajafzadeh commented 6 years ago

Type of issue

[x] Bug report.
[ ] Suggestion.

Prerequisites

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate,
[x] The issue still exists against the latest dev branch.
[x] This is not a usage question (Those should be directed to the community).
[x] I have attempted to find the simplest possible steps to reproduce the issue.

Steps to reproduce the issue (for Bug report)

Install the plugin downloaded form https://wordpress.org/plugins/admin-page-framework/
Enable the Demo
In WP Dashboard, go to APF Demo > Built-in Field Types
Go to Selectors tab
Under Check-boxes section the Sortable is not working as expected. Following I explained how to find this,

Expected behavior and actual behavior

I changed the code as follow to have one of the columns like q, r, s

            array( // sortable check boxes
                'field_id'      => 'checkbox_sortable_fields',
                'title'         => __( 'Sortable', 'admin-page-framework-loader' ),
                'type'          => 'checkbox',
                'label'         => array( 'x', 'y', 'z' ),
                'sortable'      => true,
                array(
                    'label'         => array( 'q', 'r', 's' ),
                ), // the second item
                array(), // the third item
                array(), // the fourth item
            )

Them I dragged the q, e, s row to the end and clicked Save. I was expecting to have the row at the end but, it stays at the same place and only the checked items are moved to the last.

Environment

Browsers

[x] Google Chrome
[x] Mozilla Firefox
[x] Internet Explorer

Operating System

[x] Windows
[ ] Mac OS X
[ ] Linux
[ ] Mobile

Versions

Admin Page Framework version: 3.8.15
WordPress version: 4.5.9
PHP version: 5.6.0

Isolating the problem

[x] This bug happens on the demo page.
[x] The bug happens consistently across all tested browsers.
[x] This bug happens with clean install (with the default theme and no plugin except the problematic one).

michaeluno commented 6 years ago

I was expecting to have the row at the end but, it stays at the same place and only the checked items are moved to the last.

That's how it is supposed to be. It's not a bug. You are just changing the labels of the second row, which is applied every time the rows are rendered.

If you need to let the user sort set of check boxes with different labels, you want to try nested fields or inline fields.

mnajafzadeh commented 6 years ago

Hi,

What I meant was that, the labels for check boxes are not sorting. It is only sorting the checked values!

I want to let user to sort a set of checkbox elements. Could you please, show me an example?

Thank you.

michaeluno commented 6 years ago

here https://gist.github.com/michaeluno/3c1d4d1ca39305787780f882fd7bb080

michaeluno / admin-page-framework