michaelusner / esp32-pentair-controller

Control your Pentair pool equipment via RS485->ESP32->MQTT->Home Assistant
26 stars 7 forks source link

Missing spa temperature mqtt topic #3

Open rsumner opened 2 years ago

rsumner commented 2 years ago

You've done a great job starting this project @michaelusner. I'll help contribute with testing and pull requests for code fixes and enhancements. I'm using a EasyTouch 8. I'll submit them as different issues as I discover them.

First thing I noticed is that the spa temp isn't being published as a MQTT topic. pool_temperature and air_temperature are there, but no spa_temperature.

michaelusner commented 2 years ago

@rsumner on my pool at least, the spa and pool temp are the same sensor so I just designated it as pool. Perhaps is should just be renamed as "water_temp"

rsumner commented 2 years ago

Valid point, @michaelusner. My pool also only has a single sensor. I guess the stock proto adapter returns the last value when that valve was active. I assume this was all tracked in the controller and not in the adapter.

water_temp sounds like the right approach IMO also.

michaelusner commented 1 year ago

I'm working on an ESPHome version of this project that should allow more flexibility and better integration in Home Assistant. It's still a WIP but I'll update the issues here when it's ready. A single water_temperature sensor will be the standard there.