search

michaelvillar / timer-app

A simple Timer app for Mac
MIT License
2.55k stars 197 forks source link

Add option to disable timer sound #19

Open aar0nr opened 7 years ago

aar0nr commented 7 years ago

Scares me every time when my volume is set high! 😝

karbassi commented 4 years ago

Related to #49

robinstewart commented 4 years ago

I've implemented a prototype which has a little inline volume control. Clicking the speaker icon cycles between 4 states: high volume, medium volume, low volume, and sound off. Each timer has its own volume, but new timers default to the volume setting last used.

Thoughts? I don't want to clutter this app's nice clean user interface, but this does seem like an important feature. Possibly in the future if we want to add more options (such as customizing alarm sounds and colors) this could be replaced by a "settings gear" icon that opens up a panel with all available options.

imageimageimageimage

karbassi commented 4 years ago

@robinstewart I do love the clean style of this and how each timer will have its own volume, but I think it might be best to have a preferences panel show up (separate from the timer) that allows you to set the volume (maybe a range?) and the sound played (related to #49 #61)

Thoughts?

robinstewart commented 4 years ago

I think the main advantage of having the volume right there is that it makes it very clear whether or not a sound will play when the timer goes off. Maybe you turned off the sound last time, but today you want the sound to play to make sure you don't miss it. Without the indicator there, it would be easy to forget that the setting has been changed — a potentially dangerous situation if the timer is for an important task.

So it serves as both an indicator and a control button.

@karbassi I completely agree that a panel with more options would be great to address other feature requests. But I'm ok with considering that as separate, future work.

karbassi commented 4 years ago

@robinstewart I'm okay with that. I say we push it and change it if it's a problem later.

robinstewart commented 4 years ago

I'm not sure I like this design enough yet to submit it. It would be better to have a real slide-out or pop-up panel with a volume slider, and a sleeker button icon on the main timer window, like an alert bell icon that doesn't change in size. I don't have time to do this work right now so I've just submitted #80 which is just a small back-end change which will help future efforts.

gousern commented 3 years ago

I've implemented a prototype which has a little inline volume control. Clicking the speaker icon cycles between 4 states: high volume, medium volume, low volume, and sound off. Each timer has its own volume, but new timers default to the volume setting last used.

Thoughts? I don't want to clutter this app's nice clean user interface, but this does seem like an important feature. Possibly in the future if we want to add more options (such as customizing alarm sounds and colors) this could be replaced by a "settings gear" icon that opens up a panel with all available options.

imageimageimageimage

Very cool. Volume control function looks like what I really need.

tjhewer commented 2 weeks ago

The volume control would be amazing! Using this in the context of music production to keep me on track, sometimes the speaker level is quite high during the creation process, as the source material can be rather quiet. The ability to adjust the volume would be really nice, if there’s time to implement it.

tjhewer commented 2 weeks ago

I've implemented a prototype which has a little inline volume control. Clicking the speaker icon cycles between 4 states: high volume, medium volume, low volume, and sound off. Each timer has its own volume, but new timers default to the volume setting last used.

Thoughts? I don't want to clutter this app's nice clean user interface, but this does seem like an important feature. Possibly in the future if we want to add more options (such as customizing alarm sounds and colors) this could be replaced by a "settings gear" icon that opens up a panel with all available options.

Could the volume control only appear when one hovers over the app with the cursor?