michaelwayman / node-sass-chokidar

A thin wrapper around node-sass to replicate the --watch using chokidar instead of Gaze
MIT License
291 stars 37 forks source link

Latest version breaks bulma.io #43

Closed stevensacks closed 6 years ago

stevensacks commented 6 years ago

Create React App project.

I upgraded from 0.0.3 and it doesn't work with bulma.io.

The console is filled with errors like this:

{
  "status": 1,
  "file": "/Users/steven/Development/project/node_modules/bulma/sass/layout/footer.sass",
  "line": 1,
  "column": 27,
  "message": "Undefined variable: \"$background\".",
  "formatted": "Error: Undefined variable: \"$background\".\n        on line 1 of node_modules/bulma/sass/layout/footer.sass\n>> $footer-background-color: $background !default;\n   --------------------------^\n"
}

All I'm doing is

@import 'bulma/bulma.sass';
stevensacks commented 6 years ago

It changed all the bulma files in node_modules.

=> changed: /Users/steven/Development/project/node_modules/bulma/sass/grid/columns.sass
=> changed: /Users/steven/Development/project/node_modules/bulma/bulma.sass
=> changed: /Users/steven/Development/project/src/css/style.scss
=> changed: /Users/steven/Development/project/node_modules/bulma/sass/grid/tiles.sass
=> changed: /Users/steven/Development/project/node_modules/bulma/bulma.sass

etc.

stevensacks commented 6 years ago

It breaks Jest, too.

michaelwayman commented 6 years ago

I just released a new version node-sass-chokidar@1.1.2 let me know if this fixes the issue.

stevensacks commented 6 years ago

Looks like it fixed it. Thanks!